This repository was archived by the owner on Jan 14, 2024. It is now read-only.
LONDON_10 || SAIM KORKMAZ || HTML\CSS-WEEK-4#283
Open
nsaimk wants to merge 6 commits intoCodeYourFuture:masterfrom
Open
LONDON_10 || SAIM KORKMAZ || HTML\CSS-WEEK-4#283nsaimk wants to merge 6 commits intoCodeYourFuture:masterfrom
nsaimk wants to merge 6 commits intoCodeYourFuture:masterfrom
Conversation
| .left p { | ||
| margin-right: 10px; | ||
| } | ||
| #box { |
There was a problem hiding this comment.
Great use of a mixture of classes and IDs to target different elements for styling! Nice job! 🥇
| #main-head { | ||
| display: flex; | ||
| align-items: center; | ||
| margin-top: 200px; |
There was a problem hiding this comment.
Rather than have a different line for margin-top, margin-left, margin-bottom and margin-right values; you can break these up into just one line.
So here rather than have "margin-top: 200px", "margin-bottom: 15px" and "margin-left: 240px" on different lines of code, you could try just one line that says "margin: 200px 0 15px 240px", this way you make the CSS functions slightly shorter and easier to read, hope it helps you!
| height: 30px; | ||
| background-repeat: no-repeat; | ||
| background-size: contain; | ||
| } |
There was a problem hiding this comment.
Great job! Really nice work 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.